UI Modal for Flagging ContentNodes#4375
Draft
vkWeb wants to merge 1 commit intolearningequality:unstablefrom
Draft
UI Modal for Flagging ContentNodes#4375vkWeb wants to merge 1 commit intolearningequality:unstablefrom
vkWeb wants to merge 1 commit intolearningequality:unstablefrom
Conversation
bjester
reviewed
May 6, 2024
| v-if="showFlagFeedbackModal" | ||
| v-model="showFlagFeedbackModal" | ||
| :nodeId="nodeId" | ||
| /> |
Member
There was a problem hiding this comment.
Instead of embedding the modal in each content node list item, having the component emit an event to a common place in the UI, makes more sense.
Member
Author
There was a problem hiding this comment.
I don't remember why I did this way 🤔
@ozer550 will you be willing to refactor this and take this forward?
Member
Member
Author
There was a problem hiding this comment.
Sounds good :D
Btw upon trying to remember, my mind trace says that --
Most probably I did this because Vue allows emmiting events from a parent to a direct child only. So I had to catch the event on contentnode list item, I was not able to catch the event anywhere else.
The workaround for this was to utilise an event bus. So to keep things simple I might have done this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR --
Flag contentoption to the contentnode three-dot menu.Flag contentoption that shows checkboxes for reporting a node.TO DO --
handleSubmit()method. Can only be done after Implement feedback object hierarchy #4373 is merged.Manual verification steps performed
Manual verification mainly revolves around checking when and when not
Flag contentoption is shown. So let's divide it into two parts -- first for normal users and second for admins.For normal non-admin users
Flag option should show only when these three conditions meet -- AI feature flag is enabled for user, node is not of topic kind and user does not have edit permissions on the channel, that is, all public channels that user have not created themselves.
So to test the above conditions follow the below steps --
Flag contentoption should not be there.Flag contentoption should be there.For admin users
Flag option should show in ALL channels when -- AI feature flag is enabled for admin and node is not of topic kind.
So to test the above conditions follow the below steps --
Flag contentoption should not be there.Flag contentoption should be there.Screenshots (if applicable)
1.
Flag contentoption UI2. Flag modal UI
Reviewer guidance
Performing manual verification steps should make us confident about the changes.
References
Closes #4367.
Closes #4365.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)