Add caption support with new models, vuex, and edit modal integration#4151
Open
akash5100 wants to merge 264 commits intolearningequality:gsoc/transcriptionfrom
Open
Add caption support with new models, vuex, and edit modal integration#4151akash5100 wants to merge 264 commits intolearningequality:gsoc/transcriptionfrom
akash5100 wants to merge 264 commits intolearningequality:gsoc/transcriptionfrom
Conversation
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.27.1 to 4.40.0. - [Release notes](https://github.com/fonttools/fonttools/releases) - [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst) - [Commits](fonttools/fonttools@4.27.1...4.40.0) --- updated-dependencies: - dependency-name: fonttools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [workbox-precaching](https://github.com/googlechrome/workbox) from 6.5.4 to 7.0.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v6.5.4...v7.0.0) --- updated-dependencies: - dependency-name: workbox-precaching dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
akolson
reviewed
Oct 4, 2023
bjester
reviewed
Nov 1, 2023
contentcuration/contentcuration/frontend/channelEdit/components/CaptionsTab/CaptionsTab.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/actions.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/getters.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/currentChannel/getters.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/mutations.js
Outdated
Show resolved
Hide resolved
| queryset = queryset.filter(file_id__in=file_ids) | ||
|
|
||
| if file_id: | ||
| queryset = queryset.filter(file_id=file_id) |
Member
There was a problem hiding this comment.
Similarly to the above comment, could you also check File.filter_edit_queryset here
Contributor
Author
There was a problem hiding this comment.
if file_id:
allowed_file_id = set(
File.filter_edit_queryset(
File.objects.get(pk=file_id), self.request.user
)
.values_list("id", flat=True)
)
queryset = queryset.filter(file_id=allowed_file_id)Please check this.
I think there won't be comma seperated file_ids. (we don't actually use this query for now)
contentcuration/contentcuration/frontend/shared/data/resources.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/CaptionsTab/CaptionsTab.vue
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This PR adds caption files and cues models leveraging the change event architecture. It also:
Frontend
Captionstab to the edit modal for managing and generating captions, visually controlled byfeature flagsvuexto manage the state for captions. Which is integrated into theEditModalandEditListcomponents.Backend
CaptionFileandCaptionCuemodels. The models leverage the change event architecture to track changes.Manual verification steps
TODO
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)