fix: improve validation logic for boolean fields #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix optional field validation to properly handle null, empty string, and empty array - Add explicit boolean value conversion to string for validation - Improve missing value detection with strict type checking
debba
changed the title
Member
|
Thanks for the PR @debba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
I really appreciate the Leafs project and its simplicity.
I fixed a small bug in the validation system.
Basically, these types of checks always fail.
The validator incorrectly treated false as a missing value, causing boolean validation to fail when the input was explicitly set to false.
Changes:
Updated the "required" check to only consider null, empty strings, and empty arrays as missing values.
Adjusted boolean handling so that false is properly converted to "0" before regex checks.
false is now recognized as a valid boolean value.
No impact on other validation rules or falsy values like 0 and "0".