Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Ported from rust-eventsource-client (sha f26dc37a6eb60eb31f3e106313d64b21de2c1949).

Describe the solution you've provided

This PR adds an automated workflow to keep the Minimum Supported Rust Version (MSRV) up to date, ported from rust-eventsource-client.

Changes include:

  1. New check-rust-versions.yml workflow - Runs daily and on-demand to check if the MSRV needs updating. It fetches Rust release data from endoflife.date and targets the antepenultimate (3rd most recent) stable release. When an update is needed, it automatically creates a PR updating both the env file and Cargo.toml.

  2. New .github/variables/rust-versions.env - Centralizes the MSRV (currently 1.88) so it can be referenced dynamically.

  3. Updated ci.yml - Replaced hardcoded 1.88 with dynamic version lookup from the env file in both ci-build and musl-build jobs.

  4. Updated README MSRV policy - Changed from "six months old" to "latest stable release plus two prior minor releases" to match the new automated policy.

Describe alternatives you've considered

Could continue manually updating MSRV, but automation reduces maintenance burden and ensures consistency.

Additional context

Requested by @keelerm84. Devin session

Human review checklist:

  • Verify paths in check-rust-versions.yml correctly reference launchdarkly-server-sdk/Cargo.toml for this workspace structure
  • Confirm the MSRV policy change in README aligns with team expectations

Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner January 26, 2026 17:42
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@keelerm84 keelerm84 closed this Jan 26, 2026
@keelerm84 keelerm84 reopened this Jan 26, 2026
@keelerm84 keelerm84 changed the title feat: Add MSRV auto-bump workflow and update MSRV policy chore: Create GH action to auto bump rustc Jan 26, 2026
@keelerm84 keelerm84 merged commit 78c701c into main Jan 26, 2026
8 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1776/bump-rustc-workflow branch January 26, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants