feat(java-server-sdk-redis-store): Add username/password authentication support for Redis 6.0+ #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add username field and builder method to RedisStoreBuilder - Update JedisPool constructor to pass username parameter - Add getUsername() method to RedisURIComponents for URI parsing - Update Jedis dependency to 7.1.0 (minimum 3.6.0 for ACL support) - Update README with authentication documentation This enables Redis 6.0+ ACL authentication with username/password pairs, in addition to the existing password-only authentication.
professorice
changed the title
professorice
changed the title
professorice
changed the title
tanderson-ld
requested changes
Dec 22, 2025
Contributor
tanderson-ld
left a comment
tanderson-ld
left a comment
There was a problem hiding this comment.
Tests are failing. You checked "I have added test coverage for new or changed functionality", but there are no added tests?
What testing have you done against various platforms?
...k-redis-store/src/main/java/com/launchdarkly/sdk/server/integrations/RedisURIComponents.java
Show resolved
Hide resolved
tanderson-ld
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Redis 6.0+ ACL authentication with username/password pairs, in addition to the existing password-only authentication.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.
Note
Adds ACL username/password authentication support and updates Jedis.
usernamefield andusername(String)inRedisStoreBuilder; updatesRedisStoreImplBaseto passusernametoJedisPoolRedisURIComponents.getUsernameand extends URI parsing; updates tests for username/password and explicit port usage7.1.0; CI matrix tests3.6.0and7.1.0; adjusts sed in workflow3.6.0+requirementWritten by Cursor Bugbot for commit 2a1200c. Configure here.