WIP: Add OS settings-aware dark theming#124
WIP: Add OS settings-aware dark theming#124Json-To-String wants to merge 16 commits intolabscript-suite:pyside6from
Conversation
|
Sadly the folder buttons looked decent on linux but awful on windows, back to the drawing board I suppose. |
|
Potentially helpful find, in pyside6-designer I inspected the palette and found a few more options than the qt docs lead me to believe were available: There's also a way to save custom palettes, so this could be useful for later when making custom themes. |
…n for bools, increase contrast between red and green for values
Json-To-String
force-pushed
the
pyside6-os-theming
branch
from
91554a0 to
9d1c3c3
Compare
Json-To-String
force-pushed
the
pyside6-os-theming
branch
from
5c3df31 to
040c677
Compare
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Few changes, and I'd like to hammer out the highlight situation a little more.
runmanager/__main__.py
Outdated
| else: | ||
| print(f"Unable to get color palette from os, got {check_if_light_or_dark()}") |
There was a problem hiding this comment.
This branch is no longer needed.
runmanager/__main__.py
Outdated
| if QT_ENV.lower() == 'pyqt5': | ||
| return "light" | ||
| style_hints = QtGui.QGuiApplication.styleHints() | ||
| if style_hints.colorScheme() == Qt.ColorScheme.Dark: |
There was a problem hiding this comment.
A minor style thing, but could we change this call to QtCore.Qt.ColorScheme.Dark? Then we don't need another distinct import for just this line and the call matches usage in other places.
There was a problem hiding this comment.
Oh yes that's the more pythonic way
Edit: I realize I was thinking about something else nevermind that but the suggestion is still good
runmanager/__main__.py
Outdated
| ) | ||
| from labscript_utils.qtwidgets.outputbox import OutputBox | ||
| import qtutils.icons | ||
| from qtutils.qt import QT_ENV |
There was a problem hiding this comment.
Lets merge this import into the import on line 49.
runmanager/__main__.py
Outdated
| p.color(QtGui.QPalette.Highlight) | ||
| ) |
There was a problem hiding this comment.
I'm not sure I'm sold on this change. If we are going to replace the custom highlight, we should drop it everywhere. But I'm honestly slightly more inclined to keep the custom highlight color usage here. Let's workshop it some more...
Does not handle custom colors.
Reverts using palette highlight
background brush is asked for (ie after theme change).
… between components
2 participants
This adds runmanager gui functionality to ensure PySide6 uses the correct palette if the user sets their OS theme to be light or dark.
Still to do is to ensure the highlight is sensible (Since PySide6 interacts oddly with the OS highlight and accents) and also to ensure the buttons in the top right have the correct palette applied.
