-
Notifications
You must be signed in to change notification settings - Fork 53
Update kafka and mssql: versions, user, secrets #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Neaj Morshad <neaj@appscode.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the MSSQLServer and Kafka documentation to reflect newly available versions and updated secret naming used by the operator/examples.
Changes:
- Extend MSSQLServer docs to include additional supported 2022 CUs and SQL Server 2025 RTM.
- Extend Kafka docs to include Kafka
4.0.0and update sample outputs accordingly. - Standardize Kafka auth secret naming in docs from
*-admin-credto*-authand adjust example command outputs/prompts.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/guides/mssqlserver/quickstart/quickstart.md | Updates sample msversion output to include additional MSSQLServer versions. |
| docs/guides/mssqlserver/clustering/standalone.md | Updates sample msversion output for standalone guide. |
| docs/guides/mssqlserver/clustering/ag_cluster.md | Updates sample msversion output for AG cluster guide. |
| docs/guides/mssqlserver/README.md | Adds newly supported MSSQLServer image tags to the supported versions list. |
| docs/guides/kafka/quickstart/kafka/index.md | Updates kfversion sample output (adds 4.0.0) and renames auth secret in examples. |
| docs/guides/kafka/connectcluster/quickstart.md | Updates kfversion sample output (adds 4.0.0). |
| docs/guides/kafka/concepts/kafka.md | Renames example authSecret.name to kafka-auth. |
| docs/guides/kafka/concepts/appbinding.md | Renames example AppBinding credential secret to kafka-auth. |
| docs/guides/kafka/clustering/topology-cluster/index.md | Updates secret name in sample output from *-admin-cred to *-auth. |
| docs/guides/kafka/clustering/combined-cluster/index.md | Fixes wording capitalization and updates secret names and shell prompts in examples. |
| docs/guides/kafka/cli/cli.md | Removes verbose last-applied-configuration from examples and renames auth secret to kafka-auth. |
| docs/guides/kafka/README.md | Adds Kafka 4.0.0 to supported versions list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
33a44b7 to
5fa8bb5
Compare
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
|
Visit the preview URL for this PR (updated for commit 4eaf081): https://kubedb-v2-hugo--pr842-kf-upd-gqy551dj.web.app (expires Fri, 06 Feb 2026 10:05:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
No description provided.