Add relabel config support to ServiceMonitor #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Signed-off-by: Tamal Saha <tamal@appscode.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds support for relabel configurations to the ServiceMonitor API, enabling users to customize how Prometheus labels are processed during metric scraping.
Changes:
- Added
TargetLabels,PodTargetLabels, andEndpointsfields toServiceMonitorSpec - Introduced new
Endpointtype withRelabelConfigsandMetricRelabelConfigsfields - Updated the Prometheus Operator agent to apply user-specified relabel configurations while preserving default pod label mappings
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/v1/types.go | Added Endpoint struct and extended ServiceMonitorSpec with target labels and endpoints fields to support relabel configurations |
| api/v1/zz_generated.deepcopy.go | Added generated DeepCopy methods for the new Endpoint type and updated ServiceMonitorSpec DeepCopy to handle new slice fields |
| api/v1/openapi_generated.go | Added OpenAPI schema definitions for Endpoint type and updated ServiceMonitorSpec schema with new fields |
| agents/prometheusoperator/lib.go | Enhanced agent to populate ServiceMonitor with user-specified target labels and merge custom relabel configs with default pod label mappings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.