Feat/ehk sportpalya tamogatas by Panny2507 · Pull Request #68 · kir-dev/ehk

Panny2507 · 2026-02-23T17:38:22Z

No description provided.

vercel · 2026-02-23T17:38:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ehk	Error		Feb 23, 2026 5:38pm

Copilot

Pull request overview

Adds a new “Sportpálya támogatás” (sports field support) informational page with HU/EN dictionary content and exposes it via the SPORT navigation menu.

Changes:

Added new sport.sportpalyaTamogatas dictionary entries in HU/EN.
Added a new Next.js route and React content component to render the page from the dictionary.
Updated the SPORT navigation item to link to the new page.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/dictionaries/hu.json	Adds Hungarian copy for the sports field support application page.
src/dictionaries/en.json	Adds English copy for the same page.
src/app/(app)/components/navigation-items.ts	Updates SPORT submenu to link to the new page.
src/app/(app)/[lang]/sport/sportpalyaTamogatas/page.tsx	Introduces the page route that loads dictionary content.
src/app/(app)/[lang]/sport/sportpalyaTamogatas/components/GymSupportContent.tsx	Adds the UI component that renders the structured content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T17:43:12Z

src/app/(app)/components/navigation-items.ts

            "Sports field subsidy application"
          ),
-          href: "#",
+          href: link("/sport/sportpalya-tamogatas"),


The navigation href points to /sport/sportpalya-tamogatas, but the new route directory is sport/sportpalyaTamogatas (camelCase). This will 404 at runtime. Please align the path by either renaming the folder to sportpalya-tamogatas (consistent with other routes) or updating the href to match the actual segment.

Suggested change

href: link("/sport/sportpalya-tamogatas"),

href: link("/sport/sportpalyaTamogatas"),

Copilot · 2026-02-23T17:43:13Z

src/app/(app)/[lang]/sport/sportpalyaTamogatas/page.tsx

@@ -0,0 +1,24 @@
+import { getDictionary } from '@/get-dictionary';
+import type { Locale } from '@/i18n-config';
+import { PageHeader } from '@/components/common/PageHeader';


PageHeader is imported but never used in this page component, which will fail lint/TS checks in setups that enforce no-unused-vars. Remove the unused import or render the header here (and remove it from the child component) to keep a single source of truth.

Suggested change

import { PageHeader } from '@/components/common/PageHeader';

Copilot · 2026-02-23T17:43:13Z

src/app/(app)/[lang]/sport/sportpalyaTamogatas/page.tsx

+import SportteremContent from './components/GymSupportContent';
+type SportteremIgenylesPageProps = {
+  params: Promise<{ lang: Locale }>;
+};
+export default async function SportteremIgenylesPage({
+  params,
+}: SportteremIgenylesPageProps) {
+  const { lang } = await params;
+  const dictionary = await getDictionary(lang);  
+  return (
+    <div className="min-h-screen bg-gray-50">
+      <div className="container mx-auto px-4 py-8">
+        <main className="container mx-auto py-10 px-4">
+          <SportteremContent 


The component/page/type names here refer to "Sportterem igénylés" (gym booking), but this route renders the sports field support page (dictionary.sport.sportpalyaTamogatas). Please rename the props type, page function, and local component variable to match the actual page purpose to avoid confusion and incorrect future refactors.

Suggested change

import SportteremContent from './components/GymSupportContent';

type SportteremIgenylesPageProps = {

params: Promise<{ lang: Locale }>;

};

export default async function SportteremIgenylesPage({

params,

}: SportteremIgenylesPageProps) {

const { lang } = await params;

const dictionary = await getDictionary(lang);

return (

<div className="min-h-screen bg-gray-50">

<div className="container mx-auto px-4 py-8">

<main className="container mx-auto py-10 px-4">

<SportteremContent

import SportpalyaTamogatasContent from './components/GymSupportContent';

type SportpalyaTamogatasPageProps = {

params: Promise<{ lang: Locale }>;

};

export default async function SportpalyaTamogatasPage({

params,

}: SportpalyaTamogatasPageProps) {

const { lang } = await params;

const dictionary = await getDictionary(lang);

return (

<div className="min-h-screen bg-gray-50">

<div className="container mx-auto px-4 py-8">

<main className="container mx-auto py-10 px-4">

<SportpalyaTamogatasContent

Copilot · 2026-02-23T17:43:14Z

src/dictionaries/en.json

+      },
+      "selection": { 
+        "title": "Judging Criteria",
+        "description": "The applications are evaluated by the BME Physical Education Center in cooperation with the Hungarian Academy of Sciences. The main criteria are:",


This text says the applications are evaluated "in cooperation with the Hungarian Academy of Sciences", but the Hungarian version states cooperation with EHK. This looks like an incorrect translation that will show wrong information to users; please correct the organization name in the EN dictionary entry.

Suggested change

"description": "The applications are evaluated by the BME Physical Education Center in cooperation with the Hungarian Academy of Sciences. The main criteria are:",

"description": "The applications are evaluated by the BME Physical Education Center in cooperation with the University Student Council (EHK). The main criteria are:",

Copilot · 2026-02-23T17:43:14Z

src/app/(app)/[lang]/sport/sportpalyaTamogatas/components/GymSupportContent.tsx

+import React, {JSX, ReactNode} from 'react';
+import { Card, CardContent } from '@/components/ui/card';
+import { PageHeader } from '@/components/common/PageHeader';
+import { parseFormattedText } from '@/utils/emailKatt-felkover'; //todo merge masik branchrol h letezzen a fuggveny


@/utils/emailKatt-felkover does not exist in this branch (and the comment indicates it is expected from another branch). This will break the build. Please add the missing utility in this PR or switch to an existing formatting utility used elsewhere in the repo.

Copilot · 2026-02-23T17:43:14Z

src/app/(app)/[lang]/sport/sportpalyaTamogatas/components/GymSupportContent.tsx

+import React, {JSX, ReactNode} from 'react';
+import { Card, CardContent } from '@/components/ui/card';
+import { PageHeader } from '@/components/common/PageHeader';


React and JSX are imported but not used. This is likely to trigger lint/TS unused import errors; consider importing only ReactNode (or nothing, if your TS/JSX runtime doesn’t require React in scope).

Suggested change

import React, {JSX, ReactNode} from 'react';

import { Card, CardContent } from '@/components/ui/card';

import { PageHeader } from '@/components/common/PageHeader';

import type { ReactNode } from 'react';

import { Card, CardContent } from '@/components/ui/card';

Copilot · 2026-02-23T17:43:14Z

src/app/(app)/[lang]/sport/sportpalyaTamogatas/components/GymSupportContent.tsx

+            <ol className="list-disc pl-5 space-y-1">
+              {content.condition.items.map((item, i) => (
+                <li key={i}>{parseFormattedText(item)}</li>
+              ))}
+            </ol>


This list is rendered as an <ol> but styled with list-disc (bullets), which is inconsistent semantics. Use <ul> for a bulleted list, or change the styling to list-decimal if the order matters.

Suggested change

<ol className="list-disc pl-5 space-y-1">

{content.condition.items.map((item, i) => (

<li key={i}>{parseFormattedText(item)}</li>

))}

</ol>

<ul className="list-disc pl-5 space-y-1">

{content.condition.items.map((item, i) => (

<li key={i}>{parseFormattedText(item)}</li>

))}

</ul>

Copilot · 2026-02-23T17:43:15Z

src/dictionaries/en.json

+  "sport": {
+    "sportpalyaTamogatas": {
+      "title": "Sports Field Support Application",
+      "description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK) ** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.",


Markdown bold formatting has an extra space before the closing ** in **University Student Council (EHK) **, which can render oddly depending on the formatter. Consider changing it to **University Student Council (EHK)**.

Suggested change

"description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK) ** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.",

"description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK)** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.",

Copilot · 2026-02-23T17:43:15Z

src/dictionaries/en.json

+      "period": { 
+        "title": "The Period and Location of the Support",
+        "items": ["The support applies to **a semester** (fall or spring semester) of the given academic year.", 
+        "You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory)."] 


This sentence is incomplete/awkward in English ("You can apply not only for sports activities carried out at BME sports facilities ..."). It reads like it’s missing the "but also elsewhere" part that exists in the HU version, so EN users may misunderstand the eligibility. Please revise the EN translation to match the HU meaning.

Suggested change

"You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory)."]

"You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory), but also for sports activities held at other external venues."]

Panny2507 added 3 commits January 30, 2026 14:28

page es content

c6e55e3

page

0b90a8a

sportpalyatamogatas v1

f7a2e6a

Copilot AI review requested due to automatic review settings February 23, 2026 17:38

Copilot started reviewing on behalf of Panny2507 February 23, 2026 17:39 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Feat/ehk sportpalya tamogatas#68

Feat/ehk sportpalya tamogatas#68
Panny2507 wants to merge 3 commits intomainfrom
feat/ehk-sportpalya-tamogatas

Panny2507 commented Feb 23, 2026

Uh oh!

vercel bot commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	href: link("/sport/sportpalya-tamogatas"),
	href: link("/sport/sportpalyaTamogatas"),

	"description": "The applications are evaluated by the BME Physical Education Center in cooperation with the Hungarian Academy of Sciences. The main criteria are:",
	"description": "The applications are evaluated by the BME Physical Education Center in cooperation with the University Student Council (EHK). The main criteria are:",

	"description": "The Budapest University of Technology and Economics Physical Education Center and the University Student Council (EHK) are announcing a joint application to support the rental of a sports field for BME student teams. Our goal is to support regular sports activities among the university's citizens.",
	"description": "The Budapest University of Technology and Economics Physical Education Center and the University Student Council (EHK) are announcing a joint application to support the rental of a sports field for BME student teams. Our goal is to support regular sports activities among the university's citizens.",

	"You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory)."]
	"You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory), but also for sports activities held at other external venues."]

Comments

Conversation

Panny2507 commented Feb 23, 2026

Uh oh!

vercel bot commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant