Skip to content

Fix failure cases with integration test #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierre merged 1 commit into from
Jul 6, 2025
Merged

Fix failure cases with integration test #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/killbill_client/api/net_http_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def encode_params(options = {})
options[:params][:withStackTrace] = true
end

pairs = options[:params].filter_map { |key, value|
pairs = options[:params].map { |key, value|
next if value.nil?

# If the value is an array, we 'demultiplex' into several
Expand All @@ -169,7 +169,7 @@ def encode_params(options = {})
else
"#{CGI.escape key.to_s}=#{CGI.escape value.to_s}"
end
}
}.compact
pairs.flatten!
return nil if pairs.empty?
"?#{pairs.join '&'}"
Expand Down
2 changes: 1 addition & 1 deletion lib/killbill_client/models/invoice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def cancel_subscription_dry_run(account_id, bundle_id, subscription_id, target_d
def get_invoice_template(is_manual_pay, locale = nil, options = {})

require_multi_tenant_options!(options, "Retrieving an invoice template supported in multi-tenant mode")

locale ||= 'en'

get "#{KILLBILL_API_INVOICES_PREFIX}/#{is_manual_pay ? "manualPayTemplate/#{locale}" : "template"}",
{},
Expand Down