Fix #3511: 1.21.11 Folia: Private Messages AutoMode is not working.#3512
Closed
kangobot[bot] wants to merge 1 commit intomasterfrom
Closed
Fix #3511: 1.21.11 Folia: Private Messages AutoMode is not working.#3512kangobot[bot] wants to merge 1 commit intomasterfrom
kangobot[bot] wants to merge 1 commit intomasterfrom
Conversation
Owner
|
Closing — my correction in the issue thread explains why this approach is wrong. Auto_Mode doesn't use the Conversation API, so the ProtocolLib guard is unrelated. I'll handle this separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix proposed by AI analysis of the linked issue.
Changes
main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/settings/Settings.java: Auto_Mode on Folia works when ProtocolLib is installed because BukkitPacketListener intercepts chat packets and manually forwards conversation input, working around the Folia Conversation API bug. Only disable Auto_Mode when ProtocolLib is absent.main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/settings/Settings.java: Remove the outdated Folia auto mode disabling check. The underlying threading issue (dispatching commands from the wrong thread) was fixed in Foundation's BukkitPlayer.performPlayerCommand0() which now uses player.getScheduler().run() on Folia for correct entity-thread scheduling. Auto mode no longer needs to be disabled on Folia.This is a draft PR — human review required before merging.