Initial migration of SystemPropertyExtension #5184
Closed
+2,036
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
How can I get gradle to give me infos about the actual error? The stacktrace does not help :( |
Bukama
force-pushed
the
4726_passsystempropext
branch
2 times, most recently
from
62de279 to
e31bafe
Compare
Bukama
force-pushed
the
4726_passsystempropext
branch
from
e31bafe to
db5bd86
Compare
Contributor
🚨 TestLens detected 1 failed tests 🚨Here is what you can do:
Test Summary
🏷️ Commit: 516ee2e Test FailuresModularUserGuideTests > runTestsFromUserGuideWithinModularBoundaries(Path, OutputFiles) (:platform-tooling-support-tests:test in macOS)ModularUserGuideTests > runTestsFromUserGuideWithinModularBoundaries(Path, OutputFiles) (:platform-tooling-support-tests:test in macOS)ModularUserGuideTests > runTestsFromUserGuideWithinModularBoundaries(Path, OutputFiles) (:platform-tooling-support-tests:test in macOS)Muted TestsSelect tests to mute: 🔲 ModularUserGuideTests > runTestsFromUserGuideWithinModularBoundaries(Path, OutputFiles) Reuse successful test results 🔲 ♻️ Only rerun the tests that failed or were muted before Click the checkbox to trigger a rerun: 🔲 Rerun jobs Learn more about TestLens at testlens.app. |
Contributor
Author
Contributor
|
Ah. Can you make due with (a combination of) these? |
Contributor
Author
So now back from home (message tomorrow was sent from mobile). With your changes/updates. I get at least more information from the build, like failing tests, but it stills finishes with that strange exit 
But I can continue to work on testing the migrated extension. Thank you! To your request:
|
Member
A Build Scan would be helpful. I've sent you an email. |
Member
@Bukama Could you please run these commands locally and check which of them is problematic? I suspect it's the |
Contributor
Author
Yeah that fails, I only had Will work on the PR tonight/at the weekend. |
Contributor
Author
|
I give up, I'm too stupid to make the Junit annotation find the properties and even when I apply the module patching setting from Pioneer to Junit to open java.util and java.base it does not open it. To be honest I'm too frustated to spent (the last 10 hours feel more like waste) more time. will ask another Pioneer developer to give it a try. |
Contributor
|
@Bukama I had a look at the tests, is the use of After fixing that the remaining failures appear to be functional. Are those things you can address? |
Contributor
|
Superceded by #5258 |
Contributor
Author
I don't know or remember. It was (latest) introduced / modified in a PR from 2023 where a proper way to restore sys prop was introduced. So I tried to contribute the extension exactly the way it is as this is a way we know it works. But I'm too bad to get this done. So, as written, feel free to take over. @marcphilipp also wrote me an e-mail yesterday if he should take over. |
Contributor
|
Thanks for clarifying. And no worries! I'll pick this up from here for now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs rebase after merge of LocaleExtension
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations