-
Notifications
You must be signed in to change notification settings - Fork 0
updated numpy version; added dependabot.yml #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/dependabot.yml
Outdated
| ignore: | ||
| - dependency-name: "torchmetrics" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ignore: | |
| - dependency-name: "torchmetrics" |
pyproject.toml
Outdated
| ] | ||
| dependencies = [ | ||
| "numpy<2", | ||
| "numpy>=1.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "numpy>=1.21", | |
| "numpy>=1.21,<3.0.0", |
pyproject.toml
Outdated
| dependencies = [ | ||
| "numpy<2", | ||
| "numpy>=1.21", | ||
| "scipy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an upper constraint to these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean all the other dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdeschamps
You mean sth like this?
dependencies = [
"numpy>=1.21,<3.0.0",
"scipy<=1.16.3",
"scikit-image<=0.25.2",
"torch<=2.9.1",
"torchmetrics<=1.8.2",
"tqdm<=4.67.1",
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a conflict about the
numpyversion when I tried to havecareamicsandmicrossimin auvproject.I updated
pyproject:requires-python = ">=3.9"->requires-python = ">=3.11""numpy<2"->"numpy>=1.21"To be compatible with
careamics. The notebook runs fine after the update.I also added the
dependabot.ymlto take care of dependency updates.