Skip to content

Conversation

@mese79
Copy link
Member

@mese79 mese79 commented Nov 17, 2025

There was a conflict about the numpy version when I tried to have careamics and microssim in a uv project.
I updated pyproject:
requires-python = ">=3.9" -> requires-python = ">=3.11"
"numpy<2" -> "numpy>=1.21"
To be compatible with careamics. The notebook runs fine after the update.
I also added the dependabot.yml to take care of dependency updates.

@mese79 mese79 requested a review from jdeschamps November 17, 2025 10:56
Comment on lines 9 to 10
ignore:
- dependency-name: "torchmetrics" No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ignore:
- dependency-name: "torchmetrics"

pyproject.toml Outdated
]
dependencies = [
"numpy<2",
"numpy>=1.21",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"numpy>=1.21",
"numpy>=1.21,<3.0.0",

pyproject.toml Outdated
dependencies = [
"numpy<2",
"numpy>=1.21",
"scipy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an upper constraint to these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean all the other dependencies

Copy link
Member Author

@mese79 mese79 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdeschamps
You mean sth like this?

dependencies = [
    "numpy>=1.21,<3.0.0",
    "scipy<=1.16.3",
    "scikit-image<=0.25.2",
    "torch<=2.9.1",
    "torchmetrics<=1.8.2",
    "tqdm<=4.67.1",
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jdeschamps jdeschamps merged commit f6fbfa9 into main Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants