fix: respect geo-location settings when creating notes from templates#131
Open
sh1vam31 wants to merge 1 commit intojoplin:masterfrom
Open
fix: respect geo-location settings when creating notes from templates#131sh1vam31 wants to merge 1 commit intojoplin:masterfrom
sh1vam31 wants to merge 1 commit intojoplin:masterfrom
Conversation
nishantwrp
requested changes
Feb 28, 2026
Collaborator
nishantwrp
left a comment
There was a problem hiding this comment.
this logic needs to exactly match what the main joplin app uses to figure out geolocation. this can quickly get out of sync.
I think the alternative should be either of
- making joplin expose the geolocation via a plugin API
- some changes to joplin's note creation api to automatically save geolocation if user has that setting enabled.
Contributor
Author
|
@nishantwrp, Thanks for the feedback! I understand the fix needs to happen in Joplin core. Would it be okay if I open an issue in the main Joplin repo requesting either a geolocation plugin API or auto-save in the note creation API? |
Collaborator
|
@sh1vam31 before opening the issue, i'd request you to explore joplin-core a bit to come up with some potential approaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
Notes created using templates did not include geo-location information (latitude, longitude, altitude), even when the "Save geo-location with notes" setting was enabled in Joplin preferences.
Fix
Added a new utility src/utils/geolocation.ts that:
note.saveGeolocationglobal settingnavigator.geolocationUpdated src/actions.ts to attach
latitude,longitude, andaltitudeto the note payload when geo-location is enabled.
Testing
After Fix :
