DicomSTOWRSImportService regects import, because of mising quote signs#5
Open
HannoGao wants to merge 1 commit intojohnperry:masterfrom
Open
DicomSTOWRSImportService regects import, because of mising quote signs#5HannoGao wants to merge 1 commit intojohnperry:masterfrom
HannoGao wants to merge 1 commit intojohnperry:masterfrom
Conversation
…ion/dicom": Without the quote sign, the typeLC.contains() is not matched. I don't know how it is handled in other DICOMWeb applications (or tools), so I removed the "type=", so both conditions should match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type=application/dicom vs type="application/dicom" e.g. used in python dicomweb-client
Without the quote sign, the typeLC.contains(...) is not matched. I don't know how it is handled in other DICOMWeb applications so I removed the "type=", so both conditions should match.