Bump version to 1.1.2 and improve technical PR feedback#37
Conversation
- Synchronized version across project files - Enabled real-time benchmark summary in PR comments - Cleaned up CI triggers and removed automated asset commits to comply with branch protection
Summary of ChangesHello @jmrplens, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine version update to Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version to 1.1.2 and improves the presentation of the technical benchmark report in pull request comments. The simplification of reading the benchmark report and wrapping it in a collapsible details block is a good improvement. However, by removing the image gallery generation and directly embedding the markdown, the relative image paths in the report will be broken in the PR comment. I've provided a suggestion to convert these paths to absolute URLs to ensure the images are displayed correctly.
.github/scripts/comment_pr.py
Outdated
| benchmark_report = f.read() | ||
| # Wrap the report in a details block | ||
| benchmark_report = f"### Technical Benchmark Summary\n\n<details>\n<summary>📊 View Benchmark Details</summary>\n\n{benchmark_report}\n\n</details>" |
There was a problem hiding this comment.
The benchmark report markdown contains relative paths to images (e.g., ...](.github/images/benchmark/benchmark_crossover.png)). These relative paths will not resolve correctly when the markdown is posted in a PR comment, resulting in broken images. To fix this, the image paths should be converted to absolute URLs pointing to the files in the repository.
You can use the GITHUB_REPOSITORY and GITHUB_SHA environment variables to construct the full URLs. Using raw.githubusercontent.com is recommended for displaying raw image files.
report_content = f.read()
sha = os.environ.get("GITHUB_SHA")
if repo and sha:
# Make image paths absolute so they render in the PR comment
report_content = report_content.replace("](.github/images", f"](https://raw.githubusercontent.com/{repo}/{sha}/.github/images")
# Wrap the report in a details block
benchmark_report = f"### Technical Benchmark Summary\n\n<details>\n<summary>📊 View Benchmark Details</summary>\n\n{report_content}\n\n</details>"
CI Results 🚀Test Summary
Technical Benchmark Summary📊 View Benchmark DetailsPyOctaveBand: Technical Benchmark ReportGenerated: 2026-01-07 09:22:18 1. Test Signal Parameters
2. Crossover (Linkwitz-Riley)
3. Precision & Isolation
4. Performance
|
|
CI Results 🚀Test Summary
Technical Benchmark Summary📊 View Benchmark DetailsPyOctaveBand: Technical Benchmark ReportGenerated: 2026-01-07 09:27:02 1. Test Signal Parameters
2. Crossover (Linkwitz-Riley)
3. Precision & Isolation
4. Performance
|
1 participant
No description provided.