Adding functions to find associated devices of a plant and inverters data.#54
Open
ODERZO-Flavio-2326083b wants to merge 6 commits intojgriss:mainfrom
Open
Adding functions to find associated devices of a plant and inverters data.#54ODERZO-Flavio-2326083b wants to merge 6 commits intojgriss:mainfrom
ODERZO-Flavio-2326083b wants to merge 6 commits intojgriss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for retrieving device signal data and improves device filtering.
NEW FEATURES :
get_device_data(device_id: str, signal_ids: List): retrieves measurements (signals) of a device. The docstring explains how to get the signal_ids for MPPTs measurements. Ifsignal_idsis None, it will be set to the IDs corresponding to the first 10 MPPTs voltage and intensity.CHANGED :
get_device_idsnow accepts aparent_id: str. If not None, will be used to retrieve its associated devices (inverters, loggers, meters, ...). If None, the behavior remains unchanged..Added tests covering:
get_device_dataget_device_ids(hoping this work is clean enough to be accepted, I want it to be used if it could help someone else encountering the same problems as I did!)