Open
Conversation
Dist files are only needed for pushing to npm. In order to keep commit diffs as small as possible remove dist/index.js and add dist to gitignore.
Owner
|
Let me think about this one. The thing I like about having dist checked in is that you can get the exact same code that is in NPM by checking out the repo. |
Contributor
Author
|
How about providing a README section on how to build the code? Or even some |
Contributor
Author
|
As this discussion came up at work today, here the sentence with which I argued it against my colleagues:
Just thought I drop this note here, so you get why I created the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dist files are only needed for pushing to
npm.In order to keep commit diffs as small as possible remove
dist/index.jsand add dist to.gitignore.Adds
.npmignoreto not ignoredistfolder while publishing.