Skip to content

Conversation

@afritzler
Copy link
Member

@afritzler afritzler commented Jan 20, 2026

Summary by CodeRabbit

  • Refactor
    • Removed unused scheme registration from initialization process.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

Removed the apiextensionsv1 scheme registration from the bootctl app initialization. The init function now registers only clientgoscheme, bootv1alphav1, and metalv1alpha1 schemes, eliminating an unused API extensions dependency.

Changes

Cohort / File(s) Summary
API Extensions Scheme Removal
cmd/bootctl/app/app.go
Removed apiextensionsv1 import and its scheme initialization from the init function; bootctl now registers only core schemes (clientgoscheme, bootv1alphav1, metalv1alpha1)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Update Scheme for bootctl #253: Directly opposes this change—PR #253 adds apiextensionsv1 and clientgoscheme registration to the same init function, while this PR removes apiextensionsv1 registration.

Suggested labels

area/metal-automation, size/XS

Suggested reviewers

  • damyan
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, but the template requires at least a 'Proposed Changes' section and a 'Fixes' reference. Add a description following the template format, including proposed changes and any relevant issue reference (if applicable).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the unused apiextensionsv1 scheme registration from the client initialization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@damyan damyan self-requested a review January 20, 2026 14:51
@Nuckal777 Nuckal777 merged commit 0edd334 into main Jan 20, 2026
15 checks passed
@Nuckal777 Nuckal777 deleted the chore/scheme branch January 20, 2026 16:20
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants