refactor: remove unused exports identified by ts-unused-exports#2352
refactor: remove unused exports identified by ts-unused-exports#2352
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
SgtPooki
left a comment
There was a problem hiding this comment.
a number of the removed exports are actually being used elsewhere.
| */ | ||
| // TODO: use sth else | ||
| export const realMfsPath = (path) => { | ||
| const realMfsPath = (path) => { |
There was a problem hiding this comment.
this is used by files/modals/Modals.js: import { realMfsPath } from '../../bundles/files/actions.js'
I'll look back again and will get back to you |
This PR removes unused exports that were identified by the
ts-unused-exportstool. Removing these unused exports helps in code cleanup, reduces bundle size, and improves maintainability by removing code that isn't being used elsewhere in the project. #2036Changes:
/src/bundles/files/protocol.ts(kept only re-exports ofPerform,Spawn)realMfsPathfrom/src/bundles/files/actions.jscliCmdKeys,cliCmdPrefixes,cliCommandList) from/src/bundles/files/consts.jsACTIONS,sorts,default) from/src/bundles/files/index.jscheckValidAPIAddressfrom/src/bundles/ipfs-provider.js(kept default export)sortByPropertyfrom/src/lib/sort.jsnormalizeFiles,makeCIDFromFiles,humanSize) from/src/lib/files.jsafter,once,debounce) from/src/lib/hofs/functions.jsAll functions are retained for internal use but are no longer exported.