add tests from https://github.com/nst/JSONTestSuite#3
Open
thedufer wants to merge 1 commit intoinhabitedtype:masterfrom
Open
add tests from https://github.com/nst/JSONTestSuite#3thedufer wants to merge 1 commit intoinhabitedtype:masterfrom
thedufer wants to merge 1 commit intoinhabitedtype:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across https://github.com/nst/JSONTestSuite and thought I should test jsonaf on them. It identifies a bunch of things that shouldn't parse but do. I think a lot of it is because we make no attempt to validate the contents of strings or numbers (as long as they consist of the right character sets). There are some that look potentially interesting, though, like "n_structure_single_star.json" which contains "*" (no quotes) and parses to
`Number "*".Not sure if you think this is worth merging.