matching stats as join table #3835
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
Author
There was a problem hiding this comment. ne eigentlich eher die Logik wenn es dann passt hierhin migrieren |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package com.bakdata.conquery.mode.local; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import com.bakdata.conquery.models.datasets.Dataset; | ||
| import com.bakdata.conquery.models.datasets.concepts.Concept; | ||
| import com.bakdata.conquery.models.datasets.concepts.tree.TreeConcept; | ||
| import com.bakdata.conquery.models.jobs.Job; | ||
| import com.bakdata.conquery.sql.conquery.SqlMatchingStats; | ||
| import com.google.common.base.Stopwatch; | ||
| import lombok.Data; | ||
| import lombok.ToString; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.apache.commons.lang3.builder.ToStringExclude; | ||
|
|
||
| @Slf4j | ||
| @Data | ||
| public class UpdateMatchingStatsSqlJob extends Job { | ||
|
|
||
| @ToString.Exclude | ||
| private final List<Concept<?>> concepts; | ||
| private final Dataset dataset; | ||
|
|
||
| @ToString.Exclude | ||
| private final SqlMatchingStats matchingStats; | ||
|
|
||
|
|
||
| @Override | ||
| public void execute() throws Exception { | ||
|
|
||
| log.info("BEGIN collecting SQL matching stats for {}", dataset); | ||
|
|
||
| Stopwatch stopwatch = Stopwatch.createStarted(); | ||
|
|
||
| ExecutorService executorService = Executors.newSingleThreadExecutor(); | ||
|
|
||
| List<CompletableFuture<?>> jobs = new ArrayList<>(); | ||
|
|
||
|
|
||
| for (Concept<?> concept : concepts) { | ||
| if (!(concept instanceof TreeConcept)) { | ||
| continue; | ||
| } | ||
| jobs.add(matchingStats.collectMatchingStatsForConcept((TreeConcept) concept, executorService).toCompletableFuture()); | ||
| } | ||
|
|
||
| CompletableFuture<Void> all = CompletableFuture.allOf(jobs.toArray(CompletableFuture[]::new)); | ||
| while (!all.isDone()) { | ||
| if (isCancelled()) { | ||
| all.cancel(true); | ||
| log.debug("CANCELLED update matching stats for {}", getDataset(), all.exceptionNow()); | ||
| return; | ||
| } | ||
|
|
||
| all.get(5, TimeUnit.SECONDS); | ||
| log.trace("WAITING for matching stats to finish {}", getDataset()); | ||
|
|
||
| if (all.isCompletedExceptionally()) { | ||
| log.error("FAILED update matching stats for {}", getDataset(), all.exceptionNow()); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| log.debug("DONE collecting SQL matching stats for {} within {}", dataset, stopwatch); | ||
| } | ||
|
|
||
| @Override | ||
| public String getLabel() { | ||
| return "Collect matching stats for %s (%s concepts)".formatted(dataset.getName(), concepts.size()); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hätte das Interface beibehalten und davon diese abstract Class abgeleitet.
Interfaces können auch praktisch sein, da man für diese Proxies implementieren kann