Added support for adding custom parameters to icecast.xml#8
Open
LucaTNT wants to merge 2 commits intoinfiniteproject:masterfrom
Open
Added support for adding custom parameters to icecast.xml#8LucaTNT wants to merge 2 commits intoinfiniteproject:masterfrom
LucaTNT wants to merge 2 commits intoinfiniteproject:masterfrom
Conversation
|
In my opinion the best thing would be to directly mount a local |
Author
|
That's right, but IMHO it's handy to have both the ease of setup that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to set some custom mount options, so I added the
ICECAST_EXTRA_PARAMETERSenvironment variable to allow users to specify custom xml to be added at the end of icecast.xml.It works fine in my testing, but of course the user is free to enter invalid xml which would cause Icecast not to start. To be used with caution I guess 😃