Skip to content

Implement AsSplitQuery support in AsSplitQueryEvaluator#127

Merged
wforney merged 2 commits intomainfrom
copilot/fix-code-scanning-alert
Mar 8, 2026
Merged

Implement AsSplitQuery support in AsSplitQueryEvaluator#127
wforney merged 2 commits intomainfrom
copilot/fix-code-scanning-alert

Conversation

Copy link
Contributor

Copilot AI commented Mar 8, 2026

AsSplitQueryEvaluator had the core AsSplitQuery() call permanently commented out with a TODO citing lack of EF Core support. The project now targets EF Core 9.x (AsSplitQuery available since EF Core 5.0), so this evaluator was silently a no-op despite ISpecification<T>.AsSplitQuery being set.

Changes

  • AsSplitQueryEvaluator.cs: Uncomment and activate query = query.AsSplitQuery(), add missing using Microsoft.EntityFrameworkCore import, remove stale TODO comment
// Before: silently ignored
if (specification.AsSplitQuery)
{
    //query = query.AsSplitQuery(); // TODO: Support for split query is not in the current EF Core version.
}

// After: consistent with AsNoTrackingEvaluator pattern
if (specification.AsSplitQuery)
{
    query = query.AsSplitQuery();
}
Original prompt

This section details on the original issue you should resolve

<issue_title>Fix code scanning alert - A "TODO" or similar was left in source code, possibly indicating incomplete functionality</issue_title>
<issue_description>

Tracking issue for:

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: wforney <79032+wforney@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code scanning alert for incomplete functionality Implement AsSplitQuery support in AsSplitQueryEvaluator Mar 8, 2026
@wforney wforney marked this pull request as ready for review March 8, 2026 02:06
@wforney wforney merged commit 615bd26 into main Mar 8, 2026
1 of 2 checks passed
@wforney wforney deleted the copilot/fix-code-scanning-alert branch March 8, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - A "TODO" or similar was left in source code, possibly indicating incomplete functionality

2 participants