Skip to content

Memories date fix (again)#588

Merged
JW-CH merged 1 commit intomainfrom
dev.3rob3.MemoriesDate_Again
Feb 11, 2026
Merged

Memories date fix (again)#588
JW-CH merged 1 commit intomainfrom
dev.3rob3.MemoriesDate_Again

Conversation

@3rob3
Copy link
Collaborator

@3rob3 3rob3 commented Feb 7, 2026

closes #478

Summary by CodeRabbit

  • Bug Fixes
    • Fixed date/time handling in memory search so the system uses a consistent UTC-based search date, preventing timezone-related mismatches.
    • Aligned age/year calculations with the new UTC search reference to ensure accurate results across locales.

@3rob3 3rob3 self-assigned this Feb 7, 2026
@3rob3 3rob3 added the bug Something isn't working label Feb 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Replaced local DateTime usage with a UTC-based DateTimeOffset variable (searchDate) in memory search logic and updated the year calculation to use searchDate.Year, aligning memory date calculations with UTC.

Changes

Cohort / File(s) Summary
Timezone-aware memory search
ImmichFrame.Core/Logic/Pool/MemoryAssetsPool.cs
Introduce DateTimeOffset searchDate in UTC for calls to SearchMemoriesAsync; replace DateTime.Today.ToUniversalTime() and use searchDate.Year for year calculations to align date logic with UTC.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Request memories using UTC #492: Also modifies the date input logic in MemoryAssetsPool.cs to use a UTC-based date for SearchMemoriesAsync, indicating related timezone handling changes.

Suggested labels

fix

Poem

🐰 I nibble carrots, not the clocks,
Swapped local ticks for UTC docks,
Memories line up, no dawn-delay,
Hop—sync'd days now show the right display! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately reflects the primary change: addressing a memories date/timezone bug by switching to UTC-based date calculations.
Linked Issues check ✅ Passed The changes address the core requirement from issue #478: using UTC-based date references and calculations to fix timezone-related memory display issues.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the memories date issue; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev.3rob3.MemoriesDate_Again

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@3rob3 3rob3 closed this Feb 7, 2026
@3rob3 3rob3 deleted the dev.3rob3.MemoriesDate_Again branch February 7, 2026 14:55
@3rob3 3rob3 restored the dev.3rob3.MemoriesDate_Again branch February 7, 2026 14:56
@3rob3 3rob3 changed the title range request forwarding to immich, don't buffer videos to memory Memories date fix (again) Feb 7, 2026
@3rob3 3rob3 reopened this Feb 7, 2026
@3rob3
Copy link
Collaborator Author

3rob3 commented Feb 7, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JW-CH JW-CH merged commit 7ee5ab3 into main Feb 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seeing memories from the previous day

2 participants