Minimal support of "Sec-WebSocket-Extensions: permessage-deflate"#152
Open
Inversion-des wants to merge 6 commits intoigrigorik:masterfrom
Open
Minimal support of "Sec-WebSocket-Extensions: permessage-deflate"#152Inversion-des wants to merge 6 commits intoigrigorik:masterfrom
Inversion-des wants to merge 6 commits intoigrigorik:masterfrom
Conversation
# Conflicts: # lib/em-websocket/handshake04.rb
Inversion-des
changed the title
igrigorik
reviewed
Nov 11, 2021
Owner
igrigorik
left a comment
igrigorik
left a comment
There was a problem hiding this comment.
Nice. Thanks for staging the PR, good reference! Perhaps someone else can take it over the finish line.. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/faye/permessage-deflate-ruby
I did not implement full header param processing ('client_max_window_bits' is ignored). Basically, I added changes until it started to work for me in my environment with some default hardcoded params for inflate/deflate.
So it is far from full spec implementation (https://tools.ietf.org/html/draft-ietf-hybi-permessage-compression-28).
I hope that someone will improve this code or replace with a more correct solution.