Implement XEP-0444: Message Reactions in Smack #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for XEP-0444 (Message Reactions) in Smack. Key changes include: - Added ReactionsManager to handle reactions, including adding, removing, and listening for reactions on messages. - Introduced ReactionsElement and Reaction classes to represent the <reactions> element and individual emoji reactions. - Added ReactionsFilter to detect messages containing reactions. - Implemented ReactionRestrictions to manage restrictions like max reactions per user and allowed emojis. - Integrated reaction restrictions with XMPP service discovery. - Added ReactionsListener for applications to handle incoming reactions. - Included unit tests to verify functionality. This enables emoji reactions in XMPP messages, with support for restrictions and service discovery. Related: XEP-0444 (https://xmpp.org/extensions/xep-0444.html)
Flowdalic
requested changes
Jan 30, 2025
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/ReactionsManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/ReactionsManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/ReactionsManager.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/ReactionsManager.java
Outdated
Show resolved
Hide resolved
...ental/src/main/java/org/jivesoftware/smackx/reactions/provider/ReactionsElementProvider.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/test/java/org/jivesoftware/smackx/reactions/ReactionTest.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/test/java/org/jivesoftware/smackx/reactions/ReactionTest.java
Outdated
Show resolved
Hide resolved
Implemented all requested modifications, addressed feedback, and made necessary changes. The code successfully passed the gradlew check after applying the updates.
Author
|
Hi Flowdalic! I've made all the requested changes from the previous review and addressed the feedback provided. Additionally, the code passed the gradlew check after the updates. Could you please review the PR again? Thank you for your attention!" |
Flowdalic
requested changes
Feb 18, 2025
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/element/Reaction.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/element/Reaction.java
Outdated
Show resolved
Hide resolved
...k-experimental/src/main/java/org/jivesoftware/smackx/reactions/element/ReactionsElement.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/filter/ReactionsFilter.java
Outdated
Show resolved
Hide resolved
...ental/src/main/java/org/jivesoftware/smackx/reactions/provider/ReactionsElementProvider.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/main/java/org/jivesoftware/smackx/reactions/ReactionsListener.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/test/java/org/jivesoftware/smackx/reactions/ReactionTest.java
Outdated
Show resolved
Hide resolved
...ental/src/main/java/org/jivesoftware/smackx/reactions/provider/ReactionsElementProvider.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/test/java/org/jivesoftware/smackx/reactions/ReactionTest.java
Outdated
Show resolved
Hide resolved
smack-experimental/src/test/java/org/jivesoftware/smackx/reactions/ReactionTest.java
Outdated
Show resolved
Hide resolved
- Added methods to announce reactions support - Removed support announcement from ReactionsManager constructor - Created new test classes for better coverage - Fixed form validation for reaction restrictions - Updated method signatures for consistency - Applied checkstyle fixes for code formatting
Author
|
Ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for XEP-0444 (Message Reactions) in Smack. Key changes include:
This enables emoji reactions in XMPP messages, with support for restrictions and service discovery.
Related: XEP-0444 (https://xmpp.org/extensions/xep-0444.html)