Re-export host function types through hyperlight_host#1314
Merged
jsturtevant merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
jsturtevant
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
jsturtevant
added
area/dependencies
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
rally/1286-consider-moving-the-hostfunctions-definitions-from
branch
from
2482c57 to
85192cc
Compare
simongdavies
approved these changes
Mar 16, 2026
Contributor
|
What's this needed for? And maybe the PR title could be more accurate |
jsturtevant
changed the title
Contributor
Author
I added a description, For the title I also made a small update but not sure if there is something clearer. |
ludfjig
approved these changes
Mar 17, 2026
jsturtevant
deleted the
rally/1286-consider-moving-the-hostfunctions-definitions-from
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1286
Host function definition types (HostFunctionDefinition, HostFunctionDetails, ParameterType) are currently only accessible via hyperlight_common, even though they primarily serve the host-side API. This makes it awkward for downstream consumers (e.g., hyperlight-wasm, hyperlight-js) that need to import these types alongside other host constructs.
Signed-off-by: James Sturtevant jsturtevant@gmail.com