Skip to content

Editorial pass and consistency updates#3401

Open
ekinnear wants to merge 5 commits intohttpwg:mainfrom
ekinnear:ek/editorial
Open

Editorial pass and consistency updates#3401
ekinnear wants to merge 5 commits intohttpwg:mainfrom
ekinnear:ek/editorial

Conversation

@ekinnear
Copy link

You can view just these changes at 95b51df:

  • Fix some typos, grammar, whitespace, etc.

You can view just these changes at 9a81443:

  • "A client MUST NOT send certificates to the server" vs. "The server SHOULD close the connection upon receipt" --> consistently use MUST for both endpoints
  • "A server sends a SERVER_CERTIFICATE frame on stream 0 for HTTP/2 and on the control stream for HTTP/3" --> drop the duplicate description of what's actually specified below now
  • "SERVER_CERTIFICATE_UNREADABLE" was defined but never used, update the text above to use it
  • "SERVER_CERTIFICATE_UNREADABLE" was also not in the IANA considerations section, add it

@ekinnear
Copy link
Author

Added a few more in d3e0036:

  • "Upon receiving a complete series of SERVER_CERTIFICATE frames" --> just say "frame"
  • "this SHOULD be treated as a connection error" --> MUST and be specific about the error code

Copy link
Contributor

@tfpauly tfpauly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants