[HSTACK] feat: support custom logical schemas passed through DeltaSca…#10
Open
[HSTACK] feat: support custom logical schemas passed through DeltaSca…#10
Conversation
…nConfig or through DeltaTableOldProvider
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
aditanase
reviewed
Mar 24, 2026
|
|
||
| fn schema(&self) -> Arc<Schema> { | ||
| self.snapshot().unwrap().snapshot().read_schema() | ||
| self.schema |
Collaborator
There was a problem hiding this comment.
Not sure if we're doing this processing outside, but there is some logic in read_schema / _arrow_schema that I imagine we want to apply on top of the injected schema?
| /// view types. | ||
| pub(crate) fn table_schema(&self, table_config: &TableConfiguration) -> Result<SchemaRef> { | ||
| if let Some(schema) = &self.schema { | ||
| return Ok(schema.clone()); |
Collaborator
There was a problem hiding this comment.
Same here, maybe we want to call physical_arrow_schema on top of provided schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing custom Arrow schema to the table provider in order to support some soft-version of schema evolution.
Supports TableProviderOld and DeltaScan ( next version).