Skip to content

Conversation

@stevenjoezhang
Copy link
Member

What does it do?

See #5706 (comment)

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

How to test

git clone -b external_link https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

yoshinorin

This comment was marked as outdated.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have to fix these:

'<a rel="noopenner" href="https://hexo.io/">Hexo</a>',

and

'<a href="https://hexo.io/" rel="external noopenner">Hexo</a>',

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20660067499

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.489%

Totals Coverage Status
Change from base Build 18971852506: 0.0%
Covered Lines: 9938
Relevant Lines: 9989

💛 - Coveralls

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@D-Sketon D-Sketon merged commit 1fd997c into master Jan 3, 2026
26 checks passed
@D-Sketon D-Sketon deleted the external_link branch January 3, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants