Fix price alert #100
Open
Fix price alert #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esco
requested changes
Apr 20, 2018
Member
esco
left a comment
esco
left a comment
There was a problem hiding this comment.
looking good so far, just a few changes
server/models/alert.js
Outdated
| userId = new ObjectID(userId) | ||
|
|
||
| const query = (fsym) ? {where: {fsym, userId}} : {where: {userId}} | ||
| console.log('query', query) |
Member
There was a problem hiding this comment.
protip: console.log({ query }) for faster debugging
server/models/alert.js
Outdated
|
|
||
| Alert.fetchAll = async function(access_token, {fsym}=data, cb) { | ||
| let err = null | ||
| if (!access_token || !access_token.userId) { |
Member
There was a problem hiding this comment.
Why not use the ACL json for $owner? Owner checks to see if the userId passed in the url is the same as the one on the accesstoken
server/models/alert.js
Outdated
|
|
||
| Alert.disable = async function(accessToken, {alertId}=data, cb){ | ||
| let err = null | ||
| if (!accessToken || !accessToken.userId) { |
server/models/alert.js
Outdated
|
|
||
| Alert.enable = async function(accessToken, {alertId}=data, cb){ | ||
| let err = null | ||
| if (!accessToken || !accessToken.userId) { |
samparsky
force-pushed
the
fix-price-alert
branch
from
da882bc to
27cbcb8
Compare
samparsky
force-pushed
the
fix-price-alert
branch
3 times, most recently
from
17e47b9 to
44f1258
Compare
…rice alerts, added acl definition
samparsky
force-pushed
the
fix-price-alert
branch
from
44f1258 to
aa5a1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix query