name is mandatory in edition pages, attack command (#HL#) rule implemented#580
Open
LuffyNoNika wants to merge 1 commit intomasterfrom
Open
name is mandatory in edition pages, attack command (#HL#) rule implemented#580LuffyNoNika wants to merge 1 commit intomasterfrom
LuffyNoNika wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Edition pages have generally had one FormControl line implemented to forbid empty names
-metadata.service changed for "name not empty rule" implementation for wordlists/rules/other edition pages.
-Atack command rule (new script attack-command.validator) : For both new/edit pages, validator can:
1. Tell the user "command line is required" if the input is empty
2. if only #HL# is written (default): Tells the user that #HL# plus additional is required.
3. Accept if #HL# + smth is written.
-It has been impossible to fix the issue on edit.preconfigured-task component, there were too many unfixable Lint & Prettier errors for me. In this edition page only "name not empty" rule is implemented, not for #HL#