Call push_clip() and pop_clip() when painting COLRv0 glyphs #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadaptive
force-pushed
the
push-clip-v0
branch
from
9d7814d to
5c12db6
Compare
Necessary for getting the proper glyph extents, and matches HarfBuzz.
valadaptive
force-pushed
the
push-clip-v0
branch
from
5c12db6 to
d5b6917
Compare
valadaptive
added a commit
to valadaptive/rustybuzz
that referenced
this pull request
Mar 6, 2025
They are *currently* not calculated correctly, but that's a ttf-parser issue (harfbuzz/ttf-parser#185)
Collaborator
|
Hmm... It's been a while since I implemented that, from what I remember COLRv0 doesn't really have a concept of clips, but I might be wrong. With that said, it shouldn't break any existing code and since harfbuzz has it, I'm fine with adding that. Someone else will have to merge though, since I don't have the permissions. |
valadaptive
added a commit
to valadaptive/rustybuzz
that referenced
this pull request
Mar 7, 2025
They are *currently* not calculated correctly, but that's a ttf-parser issue (harfbuzz/ttf-parser#185)
valadaptive
added a commit
to valadaptive/rustybuzz
that referenced
this pull request
Mar 8, 2025
They are *currently* not calculated correctly, but that's a ttf-parser issue (harfbuzz/ttf-parser#185)
valadaptive
added a commit
to valadaptive/rustybuzz
that referenced
this pull request
Mar 8, 2025
They are *currently* not calculated correctly, but that's a ttf-parser issue (harfbuzz/ttf-parser#185)
Member
|
Do we want a patch release cut so this is covered or should we hold off a bit until rustybuzz is ready for a release that needs it? |
Collaborator
|
I don’t think there is a rush, it’s an edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for getting the proper glyph extents in rustybuzz, and matches HarfBuzz.
We can't solve this solely in rustybuzz by just checking if the COLR table is v0 and behaving differently if so, because we can have COLRv0 glyphs in a COLRv1 table.