Skip to content

Switch to using GWCA's GetBagByIndex for safer bag pointer access; Add dye tint support to inventory item model#1490

Merged
AlexMacocian merged 1 commit intogwdevhub:release/0.9.10.5from
brendan-mccoy:master
Feb 28, 2026
Merged

Switch to using GWCA's GetBagByIndex for safer bag pointer access; Add dye tint support to inventory item model#1490
AlexMacocian merged 1 commit intogwdevhub:release/0.9.10.5from
brendan-mccoy:master

Conversation

@brendan-mccoy
Copy link
Contributor

Addresses #1489

Poking around GWCA, I encountered GWCA.GW.Items.GetBagByIndex and put that in. I'm not sure if that's the preferred solution since I'm still learning. It seems to be working.

I also found the dye_tint I also need for my effort collecting info for toolbox armory values, which I slipped in.

Switched to using GWCA's GetBagByIndex for safer bag pointer access.
@AlexMacocian AlexMacocian changed the base branch from master to release/0.9.10.5 February 28, 2026 09:24
@AlexMacocian
Copy link
Collaborator

Are you able to build this locally?

@AlexMacocian
Copy link
Collaborator

Overall I'm fine with these changes.
But try to build your branch and see if it stops the exception.

You can use the publish scripts under Scripts/ folder to build everything.

You'll need PublishWindowsX86.ps1 to build the injector and API stuff under Publish folder.

Then you'll need PublishWindows.ps1 to build the rest of the windows launcher files and the exe.

Then just launch Daybreak.exe from Publish directory

@brendan-mccoy
Copy link
Contributor Author

Yes, I've been building and testing anything before I submit a PR, using the publish scripts. Testing the inventory API, its behavior matched what my consuming use case was expecting and it was no longer throwing any exceptions in the debugger nor the 500 errors.

@AlexMacocian AlexMacocian merged commit 78646fd into gwdevhub:release/0.9.10.5 Feb 28, 2026
@AlexMacocian
Copy link
Collaborator

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants