Switch to using GWCA's GetBagByIndex for safer bag pointer access; Add dye tint support to inventory item model#1490
Merged
AlexMacocian merged 1 commit intogwdevhub:release/0.9.10.5from Feb 28, 2026
Conversation
Switched to using GWCA's GetBagByIndex for safer bag pointer access.
Collaborator
|
Are you able to build this locally? |
Collaborator
|
Overall I'm fine with these changes. You can use the publish scripts under Scripts/ folder to build everything. You'll need Then you'll need Then just launch Daybreak.exe from |
Contributor
Author
|
Yes, I've been building and testing anything before I submit a PR, using the publish scripts. Testing the inventory API, its behavior matched what my consuming use case was expecting and it was no longer throwing any exceptions in the debugger nor the 500 errors. |
Collaborator
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1489
Poking around GWCA, I encountered GWCA.GW.Items.GetBagByIndex and put that in. I'm not sure if that's the preferred solution since I'm still learning. It seems to be working.
I also found the dye_tint I also need for my effort collecting info for toolbox armory values, which I slipped in.