Export network explorer #902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rework-export-network-file
… rework-export-network-file
… rework-export-network-file
basseche
force-pushed
the
export_network_explorer
branch
4 times, most recently
from
28c9be9 to
5e920ec
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
etiennehomer
requested changes
Jan 16, 2026
| } | ||
|
|
||
| public UUID exportNetwork(UUID networkUuid, UUID studyUuid, String variantId, String fileName, String format, String userId, String parametersJson) { | ||
| public UUID exportNetwork(UUID networkUuid, UUID studyUuid, String variantId, String filename, NodeExportInfos exportInfos, String format, String userId, String parametersJson) { |
Contributor
There was a problem hiding this comment.
Move filename to NodeExportInfos ?
It will also fix your problems of too many parameters
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
export_network_explorer
branch
2 times, most recently
from
6ac474f to
82df1f8
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
export_network_explorer
branch
from
82df1f8 to
88a1c24
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
|
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
etiennehomer
requested changes
Jan 22, 2026
| this(elementUuid, elementName, type, owner, subdirectoriesCount, description, null, null); | ||
| } | ||
|
|
||
| // DTO in directory-server has others properties : creationDate, lastModificationDate |
Contributor
There was a problem hiding this comment.
To remove. It's accepted in gridsuite to duplicate dtos between servers
| studyService.assertRootNodeOrBuiltNode(studyUuid, nodeUuid, rootNetworkUuid); | ||
| UUID exportUuid = studyService.exportNetwork(studyUuid, nodeUuid, rootNetworkUuid, fileName, format, userId, parametersJson); | ||
| UUID parentDirectoryUuid = parentDirectoryUuidStr != null ? UUID.fromString(parentDirectoryUuidStr) : null; | ||
|
|
| UUID caseUuid = caseService.createCase(exportFolder + DELIMITER + exportUuid + DELIMITER + nodeExport.fileName() + ZIP_EXTENSION, "application/zip"); | ||
| directoryService.createElement(nodeExport.directoryUuid(), nodeExport.description(), caseUuid, nodeExport.fileName(), DirectoryService.CASE, userId); | ||
| } catch (Exception e) { | ||
| errorMessage = e.getMessage(); |
Contributor
There was a problem hiding this comment.
Wrong error management. You should use the new system a93f6ef
Contributor
Author
There was a problem hiding this comment.
this error will be sent in the notification
Contributor
Author
There was a problem hiding this comment.
but i can change if you wish to throw a studyException
etiennehomer
requested changes
Jan 22, 2026
| UUID exportUuid = networkConversionService.exportNetwork(networkUuid, studyUuid, variantId, fileName, format, userId, parametersJson); | ||
|
|
||
| if (exportInfos.exportToExplorer() && directoryService.elementExists(exportInfos.directoryUuid(), exportInfos.fileName(), DirectoryService.CASE)) { | ||
| throw new StudyException(ELEMENT_ALREADY_EXISTS); |
Contributor
There was a problem hiding this comment.
The snackbar is weird on front's side. Maybe the front code is to be adjusted ?
Contributor
Author
There was a problem hiding this comment.
i 've put a translation in commons-ui
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
export_network_explorer
branch
from
58a722b to
7e490c3
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary