Proper support for the SQLAlchemy Enum type#78
Merged
syrusakbary merged 2 commits intographql-python:masterfrom Nov 22, 2017
Merged
Proper support for the SQLAlchemy Enum type#78syrusakbary merged 2 commits intographql-python:masterfrom
syrusakbary merged 2 commits intographql-python:masterfrom
Conversation
|
It seems there is a problem if the same Enum is used in several classes, the code attempt to recreate the Enum with the same name.. Also there should be a way to reference the generated graphene.Enum so it can be used in queries and mutation.. |
Member
Author
|
@sboisson Thanks for the heads up - I will look into these issues this week. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemy Enums were converted to Graphene Strings by graphene-sqlalchemy so far. This is a proposed patch to convert them into Graphene Enums instead. Note that postgresql.ENUM does not need special casing since it is a subtype of the generic SQLAlchemy Enum. Also note that the patch supports the two variants of defining an SQLAlchemy Enum, namely by using a sequence and by using a Python Enum.