Merge Nightly to Production#20
Merged
Adithyan-Dinesh-Trenser merged 8 commits intoproductionfrom Feb 5, 2026
Merged
Conversation
Back merge the merge commits from production
* Added support for * Multiple studies in a single row(patient). * Navigating with series rows(filtering by series). * Multiple reviewers in the sheet. * Removed viewer dependency on hardcoded sheet columns( Now only the URL column is used ). * Fixed the sync issue in some Form panel components
…tion in rerenders
…fetching cod files
Adithyan-Dinesh-Trenser
changed the title
chengke2442
approved these changes
Feb 4, 2026
chengke2442
left a comment
chengke2442
left a comment
There was a problem hiding this comment.
LGTM. The comments are optional/non-blocking. I don't have extensive experience with TS/JS, so let’s merge this first to verify the functionality in the real environment. We can iterate on performance later if needed.
|
|
||
| public async cacheImageIds(imageIds) { | ||
| const promises: any[] = []; | ||
| return new Promise<void>(async (resolve) => { |
There was a problem hiding this comment.
Removed the nesting and refactored the function
| const values = this.formHeader.map((colName) => { | ||
| const index = this.formTemplate.findIndex((ele) => { | ||
| return colName == ele.name; | ||
| return colName == ele.columnName || colName === ele.name; |
| studiesFilteredOfDuplicates.unshift(element[0]); // making the current studyid as first element | ||
|
|
||
| rowsToCache.reduce((promise, row) => { | ||
| studiesFilteredOfDuplicates.reduce((promise, study) => { |
There was a problem hiding this comment.
not sure whether we can use Promise.all to optimized here
There was a problem hiding this comment.
This logic is necessary. Added a comment in the code describing the use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.