chore: librarian generate pull request: 20260109T152443Z #15013
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates significant updates across several Google Cloud client libraries. It introduces a new protection summary service for Google Cloud Backup and DR, enhancing capabilities for managing and reporting on resource backups. Concurrently, the Database Center API gains a powerful new method for aggregating fleet statistics, offering deeper insights into database deployments. Additionally, it includes a deprecation notice for specific justification codes in Google Cloud KMS, streamlining emergency access reporting. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated update that introduces new features for BackupDR and Database Center, along with documentation updates for KMS. The changes primarily consist of generated code. My review has identified a few minor documentation issues within the generated docstrings that could be enhanced for better clarity and readability.
| [ResourceBackupConfig.backup_configs_details][google.cloud.backupdr.v1.ResourceBackupConfig.backup_configs_details] | ||
| has a backup configuration with | ||
| [BackupConfigDetails.backup_vault][google.cloud.backupdr.v1.BackupConfigDetails.backup_vault] | ||
| set. set. |
There was a problem hiding this comment.
There appears to be a typo in the docstring. 'set. set.' should likely be 'set.'.
| set. set. | |
| set. |
| - label.value | ||
| - label.source | ||
| - has_maintenance_schedule | ||
| - has_deny_maintenance_schedules Comma separated list. |
There was a problem hiding this comment.
The phrase 'Comma separated list.' seems misplaced as part of the last item in this list. For better clarity, it should be part of the main description of the group_by field, not appended to an item.
| - has_deny_maintenance_schedules Comma separated list. | |
| - has_deny_maintenance_schedules |
| - and all fields supported by ``group_by`` The default order | ||
| is ascending. Add "DESC" after the field name to indicate | ||
| descending order. Add "ASC" after the field name to | ||
| indicate ascending order. It supports ordering using | ||
| multiple fields. For example: order_by = | ||
| "resource_groups_count" sorts response in ascending order | ||
| order_by = "resource_groups_count DESC" sorts response in | ||
| descending order order_by = "product.type, product.version | ||
| DESC, location" orders by type in ascending order, version | ||
| in descending order and location in ascending order |
There was a problem hiding this comment.
The formatting of this docstring makes it difficult to read. The list item is broken and the examples are long lines. Consider reformatting for better readability, for example by using a code block for the examples.
| - and all fields supported by ``group_by`` The default order | |
| is ascending. Add "DESC" after the field name to indicate | |
| descending order. Add "ASC" after the field name to | |
| indicate ascending order. It supports ordering using | |
| multiple fields. For example: order_by = | |
| "resource_groups_count" sorts response in ascending order | |
| order_by = "resource_groups_count DESC" sorts response in | |
| descending order order_by = "product.type, product.version | |
| DESC, location" orders by type in ascending order, version | |
| in descending order and location in ascending order | |
| - and all fields supported by ``group_by`` | |
| The default order is ascending. Add ``DESC`` after the field name to | |
| indicate descending order. Add ``ASC`` after the field name to | |
| indicate ascending order. It supports ordering using multiple | |
| fields. For example: | |
| .. code-block:: | |
| "resource_groups_count" | |
| "resource_groups_count DESC" | |
| "product.type, product.version DESC, location" |
| sqladmin.googleapis.com/Instance | ||
| alloydb.googleapis.com/Cluster | ||
| alloydb.googleapis.com/Instance | ||
| spanner.googleapis.com/Instance |
There was a problem hiding this comment.
These examples would be more readable if formatted as a code block.
| sqladmin.googleapis.com/Instance | |
| alloydb.googleapis.com/Cluster | |
| alloydb.googleapis.com/Instance | |
| spanner.googleapis.com/Instance | |
| .. code-block:: | |
| sqladmin.googleapis.com/Instance | |
| alloydb.googleapis.com/Cluster | |
| alloydb.googleapis.com/Instance | |
| spanner.googleapis.com/Instance |
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupLocationis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ListResourceBackupConfigsResponseis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new resource_definition
backupdr.googleapis.com/ResourceBackupConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupConfigDetailsis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrTemplateConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrPlanRuleis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ListResourceBackupConfigsRequestis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new service
BackupDrProtectionSummaryis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ResourceBackupConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
PitrSettingsis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrPlanConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: google-cloud-backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Marking MODIFIED_CUSTOMER_INITIATED_ACCESS and MODIFIED_GOOGLE_INITIATED_SYSTEM_OPERATION Key Access Justification codes as deprecated in favor of GOOGLE_RESPONSE_TO_PRODUCTION_ALERT
PiperOrigin-RevId: 853754070
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@f8142673
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Adding Method AggregateFleet of Database Center API v1beta
This release includes:
DatabaseCenterservice withAggregateFleetmethod.PiperOrigin-RevId: 853112628
Library-IDs: google-cloud-databasecenter
Source-link: googleapis/googleapis@5f9683c0
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@d4a34bf0
(exclusive) and
googleapis/googleapis@524b2de6
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209