Skip to content

add solar calculation in weather_controller and define fenestration constants#165

Open
ecosang wants to merge 2 commits intogoogle:copybara_pushfrom
ecosang:weather_controller
Open

add solar calculation in weather_controller and define fenestration constants#165
ecosang wants to merge 2 commits intogoogle:copybara_pushfrom
ecosang:weather_controller

Conversation

@ecosang
Copy link
Contributor

@ecosang ecosang commented Mar 16, 2026

add solar calculation in weather_controller and define fenestration constants

…onstants, and add relative convergence argument in simulator
@ecosang
Copy link
Contributor Author

ecosang commented Mar 16, 2026

@s2t2 I've put only weather controller part in this PR.

@s2t2
Copy link
Collaborator

s2t2 commented Mar 19, 2026

OK, thanks! I see the build is failing due to CSV path issues (see below). Would you please fix and then ping me and I will review again when the build is passing.

FAILED smart_control/simulator/weather_controller_test.py::ReplayWeatherControllerPvlibValidationTest::test_replay_controller_irradiance_closure_equation - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/sbsim/sbsim/smart_control/simulator/../configs/resources/sb1/weather_data/local_weather_test_data.csv'

@ecosang
Copy link
Contributor Author

ecosang commented Mar 19, 2026

@s2t2 the csv file is automatically ignored. I just added. Sorry for the iteration. Can I also check if the testing is passed here on my end? when I made PR, I didn't see the failure. Maybe I didn't wait enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants