add solar calculation in weather_controller and define fenestration constants#165
add solar calculation in weather_controller and define fenestration constants#165ecosang wants to merge 2 commits intogoogle:copybara_pushfrom
Conversation
…onstants, and add relative convergence argument in simulator
|
@s2t2 I've put only weather controller part in this PR. |
|
OK, thanks! I see the build is failing due to CSV path issues (see below). Would you please fix and then ping me and I will review again when the build is passing.
|
|
@s2t2 the csv file is automatically ignored. I just added. Sorry for the iteration. Can I also check if the testing is passed here on my end? when I made PR, I didn't see the failure. Maybe I didn't wait enough. |
add solar calculation in weather_controller and define fenestration constants