Implement metrics command (google/clasp#353)#757
Open
kalmi wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Contributor
|
@kalmi can you give a look at the failing test? |
Contributor
Author
|
I think the token used by the CI needs to be recreated with the new scopes. I think it comes from the CREDS env variable. |
Contributor
|
@kalmi sorry for the late reply, I no longer use clasp and rarely check this repo. If this PR is still relevant, can you give a shot at resolving the above conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353. CI breakage is expected due to scopes change.
Only basic metrics listing is implemented from the data provided by the getMetrics API.
Example:
npm run testsucceeds.npm run lintsucceeds.A separate issue could be opened for extending the metrics command with data provided by the processes API. There is a lot of potential in the processes API for extending this command.