Skip to content

Add exports for MSVC build#125

Open
lucianpls wants to merge 3 commits intogoogle:masterfrom
lucianpls:win32-exports
Open

Add exports for MSVC build#125
lucianpls wants to merge 3 commits intogoogle:masterfrom
lucianpls:win32-exports

Conversation

@lucianpls
Copy link

On Windows, MSVC needs to have explicit exports for public symbols.

@lucianpls
Copy link
Author

I did sign the CLA

@eustas
Copy link
Collaborator

eustas commented Sep 20, 2023

Hi. I'm going to do that via CMake "exports" file generation soon. Please don't close this PR, so it won't fall off my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants