Don't unnecessarily copy the input ImmutableSetMultimap.#2026
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Don't unnecessarily copy the input ImmutableSetMultimap.#2026copybara-service[bot] wants to merge 0 commit intomainfrom
ImmutableSetMultimap.#2026copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_872548716
branch
from
692e744 to
0006d28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't unnecessarily copy the input
ImmutableSetMultimap.The copy hasn't been necessary since the type change in cl/316968142.
(Calling
ImmutableSetMultimap.copyOfon anImmutableSetMultimapinstance is not always a no-op: It can be used to "trim" a partial view, which I think you could get fromsomeImmutableSortedMap.subMap(...).asMultimap()or something. But I don't think that's what's going on here, and even if it were, this CL would probably still be an improvement.)(Incidentally, the implementation of the
privateoverload ofImmutableSetMultimap.copyOflooks a bit scary. But that's a job for cl/872557235.)RELNOTES=n/a