Open
Conversation
pjbgf
requested changes
Jul 24, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@this-kirke thanks for proposing these changes. Please take a look at the feedback below.
this-kirke
force-pushed
the
feature/update-embedfs
branch
4 times, most recently
from
0f56f9c to
6ad6516
Compare
Author
|
Hi Paulo! Thank you for the review. I've updated with requested changes; all tests pass. |
pjbgf
requested changes
Jul 27, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@this-kirke Thanks for the follow up. I just did a full review now, there are a few tests that are redundant which we can remove. But otherwise it LGTM.
Please squash your commits once you are done with the changes below.
Author
|
Thank you for the detailed review! I agree on all points. I think everything should be resolved now; please let me know if there's anything else you notice. We can squash on complete. |
this-kirke
force-pushed
the
feature/update-embedfs
branch
from
5cb6e4d to
b89ce64
Compare
- Fix path normalization to support billy's absolute path convention ("/")
- Implement missing Lstat method (was returning ErrNotSupported)
- Add proper embed.FS to billy path conversion throughout all methods
Additional test coverage:
- Add dedicated test files for different functionality areas
- Test File interface methods including ReadAt, Close, Lock/Unlock
- Add path normalization and edge case testing
- Test empty file handling and boundary conditions
- Verify proper error handling for read-only operations
Test infrastructure:
- Create embedfs_testdata package for reusable test data
- Resolve import cycles with clean provider pattern
- Add test data including nested directories and various file types
- Organize tests by functionality (fs, dir, file operations)
The embedfs implementation now provides billy.Filesystem compliance
for read-only embedded filesystems.
- Remove memfs dependency and use local sorting for ReadDir - Implement chroot support by wrapping embedfs with chroot.New() in New() - Add comprehensive chroot tests covering read-only operations - Follow same pattern as memfs and osfs for consistent API - Maintain read-only behavior - write operations still return ErrReadOnly This enables embedfs to work with filesystem abstractions that require chroot support for path isolation.
- Move embedfs_testdata directory to embedfs/internal/testdata
- Change package name from embedfs_testdata to testdata
- Update all import paths in test files to use new location
- Update function calls from embedfs_testdata.GetTestData() to testdata.GetTestData()
- Fix test expectations for ReadDir("") to match actual billy filesystem behavior
- Fix file name assertion to match embedded filesystem path structure
- Add missing newlines to end of test files
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
pjbgf
force-pushed
the
feature/update-embedfs
branch
from
b89ce64 to
7774d7e
Compare
Member
|
Quite a few suggestions I made were marked as resolved without them being acted upon. I added some of them on the last commit, but don't really have the time atm to review everything that was incorrectly marked as resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to embedfs implementation:
Additional test coverage:
Test infrastructure:
The embedfs implementation now provides billy.Filesystem compliance for read-only embedded filesystems.