refactor: use GitifyNotification type with transformation layer #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a clean separation between raw GitHub API types and internal Gitify notification types: - Add transform.ts at API boundary to convert raw GitHub responses - Define GitifyNotification, GitifySubject, GitifyRepository, GitifyOwner types with camelCase properties - Update all components, handlers, filters, and utilities to use new types - Update GraphQL schema aliases for consistent property naming - Remove Notification type alias from typesGitHub.ts Closes #828
Member
|
Close #828 |
setchy
reviewed
Dec 29, 2025
setchy
reviewed
Dec 29, 2025
setchy
reviewed
Dec 29, 2025
setchy
reviewed
Dec 29, 2025
setchy
reviewed
Dec 29, 2025
Member
|
After we land this PR, I'd love to start pulling out some of the formatting / logic within the UI components and pushing them into this api/transformation layer. eg: things like formatting notification titles, and so forth... |
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
setchy
approved these changes
Dec 29, 2025
Member
setchy
left a comment
setchy
left a comment
There was a problem hiding this comment.
Awesome, @afonsojramos - nice work! 👏
afonsojramos
added a commit
that referenced
this pull request
Dec 30, 2025
* refactor: use GitifyNotification type with transformation layer Introduce a clean separation between raw GitHub API types and internal Gitify notification types: - Add transform.ts at API boundary to convert raw GitHub responses - Define GitifyNotification, GitifySubject, GitifyRepository, GitifyOwner types with camelCase properties - Update all components, handlers, filters, and utilities to use new types - Update GraphQL schema aliases for consistent property naming - Remove Notification type alias from typesGitHub.ts Closes #828 * further type refactoring Signed-off-by: Adam Setch <adam.setch@outlook.com> * further type refactoring Signed-off-by: Adam Setch <adam.setch@outlook.com> * further type refactoring Signed-off-by: Adam Setch <adam.setch@outlook.com> * further type refactoring Signed-off-by: Adam Setch <adam.setch@outlook.com> --------- Signed-off-by: Adam Setch <adam.setch@outlook.com> Co-authored-by: Adam Setch <adam.setch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the notification type system to use a unified
GitifyNotificationtype throughout the application, introducing a transformation layer at the API boundary to convert raw GitHub responses to the internal type format.Closes #828
Changes
transform.ts) to convert raw GitHub API responses toGitifyNotificationformatTesting