feat: always include files from diff in overlay changed files

[sam-robson]

Ensure that overlay changes always include all PR diff files used for diff-informed analysis.

Risk assessment

For internal use only. Please select the risk level of this change:

• Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

• Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

• Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
• Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

• Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
• GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

• Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
• End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

• Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

• Telemetry - I rely on existing telemetry or have made changes to the telemetry.
  • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
  • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

• No special considerations - This change can be merged at any time.
• Special considerations - This change should only be merged once certain preconditions are met. Please provide details of those or link to this PR from an internal issue.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Consider adding a changelog entry for this change.
• Confirm the readme and docs have been updated if necessary.

[Copilot]

Pull request overview

This PR ensures overlay analysis always includes all files present in the PR diff by persisting PR diff-range data during init, reusing it during analyze, and merging diff-derived paths into the overlay “changed files” list to cover cases like revert PRs.

Changes:

• Persist PR diff ranges to pr-diff-range.json during init when diff-informed analysis is enabled.
• Update analyze to read precomputed diff ranges from disk instead of recomputing via API calls.
• Merge diff-derived file paths into overlay changed files and add unit tests covering diff-only/revert-like cases.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/overlay/index.ts	Merges OID-changed files with PR diff-derived file paths for overlay changes.
src/overlay/index.test.ts	Adds tests verifying diff-derived files are merged/deduplicated and behavior is unchanged when the diff file is absent.
src/init-action.ts	Computes and persists PR diff ranges during init (non-fatal on failure).
src/analyze.ts	Switches diff-informed setup to read precomputed diff ranges from disk.
src/analyze-action.ts	Simplifies diff-informed setup call to rely on precomputed diff file presence.
lib/*	Generated JavaScript output corresponding to the TypeScript changes.

Comments suppressed due to low confidence (1)

src/overlay/index.ts:185

• getDiffRangeFilePaths will throw if pr-diff-range.json is missing required fields, malformed JSON, or not an array. Since this file is optional and lives in the temp directory, it would be safer for overlay mode to treat parse/shape errors as non-fatal (log a warning/debug and return []) so overlay database creation doesn’t fail due to a stale/corrupted temp file.

function getDiffRangeFilePaths(logger: Logger): string[] {
  const jsonFilePath = path.join(getTemporaryDirectory(), "pr-diff-range.json");
  if (!fs.existsSync(jsonFilePath)) {
    return [];
  }
  const diffRanges = JSON.parse(
    fs.readFileSync(jsonFilePath, "utf8"),
  ) as Array<{ path: string }>;
  logger.debug(
    `Read ${diffRanges.length} diff range(s) from ${jsonFilePath} for overlay changes.`,
  );
  return [...new Set(diffRanges.map((r) => r.path))];

[Copilot]

pr-diff-range.json paths are repo-root relative (from the GitHub compare API), but computeChangedFiles returns paths relative to sourceRoot (because getFileOidsUnderPath(sourceRoot) returns paths relative to basePath). Merging these lists as-is will produce incorrect overlay paths when source-root is not the repository root, and may cause the CLI to treat files as missing/outside the source root.

Consider converting diff-range paths to be relative to sourceRoot (and filtering out files not under sourceRoot) before merging, e.g. by deriving the repo root/checkout_path and stripping the sourceRoot prefix in a platform-independent way.

This issue also appears on line 174 of the same file.

[redsun82]

☝️ this seems like a real bug to me

[Copilot]

setupDiffInformedQueryRun now relies on readDiffRangesJsonFile, which does an unconditional JSON.parse. If the temp file exists but is corrupted/partially written, this will throw and abort the analyze step. Since diff-informed analysis is an optional optimization, consider catching parse errors here (or making readDiffRangesJsonFile return undefined on parse failure) and falling back to full analysis with a warning.

[redsun82]

this should probably be extracted to a getPrDiffRangeFile function to avoid repeating the magic constant file name