Add check to prevent infinite retry loops in check run failure handler #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MAX_GITAUTO_COMMITS_PER_PR constant (50) to prevent infinite loops - Create get_pull_request_commits() to fetch PR commits via GitHub API - Check commit count in check_suite_handler before processing - Post conversational comment on PR when stopping after too many attempts - Add comprehensive tests for get_pull_request_commits() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The tests were hanging because the function uses a while True loop that fetches pages until an empty response is received. The mocks were returning the same non-empty response indefinitely, causing an infinite loop. Fixed by using side_effect to return commits on first call and empty list on second call to properly break the pagination loop. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code