-
Notifications
You must be signed in to change notification settings - Fork 571
fix(integrations): Anthropic: add content transformation for images and documents #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantinius
wants to merge
2
commits into
constantinius/fix/redact-message-parts-type-blob
Choose a base branch
from
constantinius/fix/integrations/anthropic-redact-image-data-messages
base: constantinius/fix/redact-message-parts-type-blob
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+830
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The new logic skips
tool_resultcontent blocks. If a user message contains onlytool_resultblocks, the entire message will be silently dropped, losing observability data.Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The new logic at this location explicitly skips any content block with
typeequal totool_result. In Anthropic's tool-calling workflow, it is a common pattern for a user message to contain onlytool_resultblocks. When this occurs, the loop will skip all content blocks, leaving thetransformed_contentlist empty. Consequently, the subsequentif transformed_content:check will fail, and the entire message will be silently dropped from the Sentry event. This results in a loss of observability for tool-calling interactions, making it impossible to trace the full conversation flow in Sentry for users of this feature.💡 Suggested Fix
Instead of completely skipping
tool_resultblocks, they should be processed and included in thenormalized_messages. A potential fix is to handle them similarly to other content types, ensuring they are not dropped, while still considering the redaction concerns that motivated the original change. This might involve selectively redacting sensitive fields within thetool_resultinstead of removing it entirely.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
8340295