Skip to content

feat(crashpad): offline caching #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpnurmi wants to merge 13 commits into
base: jpnurmi/feat/offline-caching
Choose a base branch
from
Open

feat(crashpad): offline caching #1493

jpnurmi wants to merge 13 commits into from
+356 −2

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jan 26, 2026 •
edited
Loading

Converts completed Crashpad reports to Sentry envelopes for offline caching.

  1. After N upload/retry attempts, Crashpad moves reports to <db>/completed/
  2. On the next SDK init, the Crashpad backend iterates over completed reports
    • Each report is converted into a Sentry envelope stored in <db>/cache/
  3. Cache pruning is applied as usual

Depends on:

See also:

This was referenced Jan 26, 2026
Merged
Merged
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch 4 times, most recently from 4dd6c5e to ff864c4 Compare January 26, 2026 15:27
@jpnurmi jpnurmi mentioned this pull request Feb 3, 2026
Open
2 tasks
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch from ff864c4 to a3db389 Compare February 4, 2026 08:48
@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Feb 4, 2026

@sentry review

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Feb 4, 2026

@cursor review

cursor[bot]
cursor bot reviewed Feb 4, 2026
View reviewed changes
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch from a3db389 to 1cc6a7e Compare February 4, 2026 09:33
@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Feb 4, 2026

@cursor review

cursor[bot]
cursor bot reviewed Feb 4, 2026
View reviewed changes
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch from 1cc6a7e to 7fc7a78 Compare February 4, 2026 11:10
@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Feb 4, 2026

@cursor review

cursor[bot]
cursor bot reviewed Feb 4, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

jpnurmi added a commit that referenced this pull request Feb 9, 2026
@jpnurmi
WIP: feat(crashpad): offline caching (#1493)
2c3a4b2
jpnurmi and others added 5 commits February 10, 2026 10:27
@jpnurmi
WIP: feat(crashpad): offline caching
683e521
@jpnurmi @claude
fix(tests): add httpserver.wait to crashpad cache tests
d03d9fb 
Wait for minidump upload to complete before proceeding in the cache
tests to fix flaky CI failures across all platforms.

Also reorder test_crashpad_cache_max_age to set file mtimes before
the 5th crash to avoid timing issues with the cache.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@jpnurmi
chore: update changelog
badab46
@jpnurmi @claude
fix(crashpad): skip processing completed reports when cache is disabled
ceb4912 
Fixes test_crashpad_dumping_crash by checking for options->cache_keep
before attempting to process completed reports.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@jpnurmi @claude
fix(crashpad): skip report conversion when event data is missing
4031e45 
Prevents creating malformed envelopes when __sentry-event file is
missing or contains invalid msgpack data.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch from 7fc7a78 to 4031e45 Compare February 10, 2026 09:28
@jpnurmi jpnurmi changed the base branch from master to jpnurmi/feat/offline-caching February 10, 2026 09:29
@jpnurmi jpnurmi changed the title WIP: feat(crashpad): offline caching feat(crashpad): offline caching Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 97b2723

@jpnurmi jpnurmi marked this pull request as ready for review February 10, 2026 09:32
cursor[bot]
cursor bot reviewed Feb 10, 2026
View reviewed changes
jpnurmi and others added 2 commits February 10, 2026 11:53
@jpnurmi @claude
fix(crashpad): missing DSN header in cached envelopes
bd2bafe 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jpnurmi @claude
fix(crashpad): check return value of sentry__envelope_add_event
f5e6a7a 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentry[bot]
sentry bot reviewed Feb 10, 2026
View reviewed changes
jpnurmi and others added 2 commits February 10, 2026 12:09
@jpnurmi @claude
refactor(crashpad): inline report_minidump_path
0c291b1 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jpnurmi @claude
fix(crashpad): skip caching already cached reports
30e3320 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentry[bot]
sentry bot reviewed Feb 10, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Feb 10, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

jpnurmi and others added 3 commits February 10, 2026 12:26
@jpnurmi @claude
fix(crashpad): decref event when sentry__envelope_add_event fails
8a22d2c 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jpnurmi @claude
fix(crashpad): delete completed report when cache file already exists
7c72f1c 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jpnurmi @claude
docs(crashpad): add comments to report_to_envelope and process_comple…
97b2723 
…ted_reports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@mujacica mujacica mujacica approved these changes

@JoshuaMoelans JoshuaMoelans Awaiting requested review from JoshuaMoelans

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpnurmi @mujacica