Skip to content

chore: add commit skill for Claude, Cursor, and Codex#16804

Merged
sergical merged 2 commits intomasterfrom
add-commit-skill
Mar 5, 2026
Merged

chore: add commit skill for Claude, Cursor, and Codex#16804
sergical merged 2 commits intomasterfrom
add-commit-skill

Conversation

@sergical
Copy link
Member

@sergical sergical commented Mar 5, 2026

DESCRIBE YOUR PR

Add the commit skill from getsentry/skills for Claude Code, Cursor, and Codex agents.

  • .agents/skills/commit/ — universal skill (Cursor, Codex, Cline, Gemini CLI, GitHub Copilot, etc.)
  • .claude/skills/commit — symlink for Claude Code
  • skills-lock.json — lock file for installed skills

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Co-Authored-By: Claude noreply@anthropic.com

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Mar 5, 2026 8:16pm
sentry-docs Ready Ready Preview, Comment Mar 5, 2026 8:16pm

Request Review

@sergical sergical marked this pull request as ready for review March 5, 2026 17:26
Addresses PR #16804 review comment about missing create-branch skill
dependency. Also cleans up extra agent directories from initial install.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@szokeasaurusrex
Copy link
Member

Wouldn't it be better to use dotagents here?

Tbh I haven't tried it out yet, but based on that docs page, this use case seems like exactly what dotagents is designed to handle -- the ability to reuse a skill defined elsewhere without needing to copy paste it.

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 🚀

agents.toml Outdated
Comment on lines +1 to +3
version = 1
# Skills are checked into git so collaborators don't need to run 'dotagents install'.
gitignore = false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The agents.toml configuration lists cursor and codex as agents, but the required symlinks (.cursor/skills, .codex/skills) are not checked into the repository, unlike .claude/skills.
Severity: MEDIUM

Suggested Fix

To ensure the configuration works as intended for all declared agents without requiring an install step, check in the missing symlinks for .cursor/skills and .codex/skills. Alternatively, if support for these agents is not ready, remove cursor and codex from the agents list in agents.toml.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: agents.toml#L1-L3

Potential issue: The `agents.toml` file sets `gitignore = false` and lists `cursor` and
`codex` in the `agents` field. The intent, as stated in a comment, is that collaborators
do not need to run `dotagents install`. However, while the skills and the
`.claude/skills` symlink are checked in, the corresponding symlinks for `.cursor/skills`
and `.codex/skills` are missing from the repository. Without these symlinks, Cursor and
Codex agents will fail to discover the skills unless a collaborator manually runs
`dotagents install`, which contradicts the intended setup.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.


## References

- [Sentry Commit Messages](https://develop.sentry.dev/engineering-practices/commit-messages/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor contribution guidelines deleted without equivalent replacement

Medium Severity

The 310-line .cursor/rules/contribution-guidelines.mdc is deleted but its content — covering MDX file structure, frontmatter fields, component usage (PlatformContent, OnboardingOptionButtons, alerts, expandable sections), content resolution priority, platform-specific guidelines, file naming conventions, navigation/sidebar ordering, and common anti-patterns — is not replaced by the new commit and create-branch skills. The existing .agents/skills/technical-docs/ and .agents/skills/docs-review/ only partially overlap. Cursor loses substantial project-specific documentation guidance.

Fix in Cursor Fix in Web

agents.toml Outdated
version = 1
# Skills are checked into git so collaborators don't need to run 'dotagents install'.
gitignore = false
agents = ["claude", "cursor", "codex"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor lacks skills symlink unlike Claude setup

Medium Severity

agents.toml declares agents = ["claude", "cursor", "codex"] and the PR creates .claude/skills as a symlink to ../.agents/skills, but no corresponding .cursor/skills symlink or Cursor rule file is created. Since gitignore = false means skills are checked into git (no dotagents install needed), Cursor has no mechanism to discover the new skills. The PR title promises skills for Cursor but Cursor gets nothing while losing its existing rules.

Additional Locations (1)

Fix in Cursor Fix in Web

@sergical
Copy link
Member Author

sergical commented Mar 5, 2026

Wouldn't it be better to use dotagents here?

Tbh I haven't tried it out yet, but based on that docs page, this use case seems like exactly what dotagents is designed to handle -- the ability to reuse a skill defined elsewhere without needing to copy paste it.

i tried to use dotagents but i am not sure its properly equipped for this usecase. just doing the skills.sh installs for now

@sergical sergical merged commit 4b50a4d into master Mar 5, 2026
28 checks passed
@sergical sergical deleted the add-commit-skill branch March 5, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants